Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BCD in front-runner (remaining api/[abc]*; manual) #5551

Merged
merged 3 commits into from
Jun 2, 2021
Merged

Move BCD in front-runner (remaining api/[abc]*; manual) #5551

merged 3 commits into from
Jun 2, 2021

Conversation

teoli2003
Copy link
Contributor

What was wrong/why is this fix needed? (quick summary only)

We want to have browser-compat in front-runner: this allows us to write {{Compat}} without parameter, and in the future, {{Spec}} (and likely more).

This PR covers api/[abc]* for the cases refused by the script (that is defensive).

MDN URL of the main page changed

10 files in api/*

Issue number (if there is an associated issue)

openwebdocs/project#36

Anything else that could help us review it

  • 2 files had a wrong name; I renamed them
  • there was a couple of cases with useless param
  • and a few case with a wrong parameter (I moved it and fixed it).

@teoli2003 teoli2003 requested a review from a team as a code owner June 1, 2021 17:53
@teoli2003 teoli2003 requested review from sideshowbarker and removed request for a team June 1, 2021 17:53
@teoli2003 teoli2003 mentioned this pull request Jun 1, 2021
Closed
51 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2021

Preview URLs

Flaws

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/CSSNumericValue/sum
Title: CSSNumericValue.sum()
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.CSSNumericValue.sum

URL: /en-US/docs/Web/API/CSSPseudoElement
Title: CSSPseudoElement
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/Element/pseudo does not exist
    • /en-US/docs/Web/API/Element/pseudo does not exist

URL: /en-US/docs/Web/API/CSSPseudoElement/element
Title: CSSPseudoElement.element
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/Element/pseudo does not exist
    • /en-US/docs/Web/API/Element/pseudo does not exist

URL: /en-US/docs/Web/API/CSSPseudoElement/type
Title: CSSPseudoElement.type
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/Element/pseudo does not exist
    • /en-US/docs/Web/API/Element/pseudo does not exist

URL: /en-US/docs/Web/API/CSS
Title: CSS
on GitHub
Flaw count: 35

  • broken_links:
    • Can't resolve /en-US/docs/Components.utils.importGlobalProperties
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 29 more flaws omitted

External URLs

URL: /en-US/docs/Web/API/CSSNumericValue/sum
Title: CSSNumericValue.sum()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSSPseudoElement
Title: CSSPseudoElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSSPseudoElement/element
Title: CSSPseudoElement.element
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSSPseudoElement/type
Title: CSSPseudoElement.type
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSS
Title: CSS
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSS/RegisterProperty
Title: CSS.registerProperty()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/ClipboardItem/presentationStyle
Title: ClipboardItem.presentationStyle
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BluetoothCharacteristicProperties/writableAuxiliaries
Title: BluetoothCharacteristicProperties.writableAuxiliaries
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/BluetoothCharacteristicProperties/writeWithoutResponse
Title: BluetoothCharacteristicProperties.writeWithoutResponse
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/CSSTransition/transitionProperty
Title: CSSTransition.transitionProperty
on GitHub

No new external URLs

wbamberg
wbamberg reviewed Jun 1, 2021
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe if we change the slug we ought to add a redirect?

files/en-us/web/api/bluetoothcharacteristicproperties/writableauxiliaries/index.html Show resolved Hide resolved
files/en-us/web/api/bluetoothcharacteristicproperties/writewithoutresponse/index.html Show resolved Hide resolved
files/en-us/web/api/csspseudoelement/type/index.html Show resolved Hide resolved
@teoli2003 teoli2003 requested a review from a team as a code owner June 2, 2021 04:42
@teoli2003 teoli2003 requested review from Rumyra and removed request for a team June 2, 2021 04:42
wbamberg
wbamberg approved these changes Jun 2, 2021
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good: great work @teoli2003 !

@wbamberg wbamberg merged commit 61dc59e into mdn:main Jun 2, 2021
@teoli2003 teoli2003 deleted the move-bcd-in-front-runner-api-manual-part-1 branch June 2, 2021 06:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker

@Rumyra Rumyra Awaiting requested review from Rumyra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoli2003 @wbamberg